From: Colin Walters Date: Mon, 17 Mar 2025 23:09:53 +0000 (-0400) Subject: commit: Clarify that syncfs is of repo/tmp X-Git-Tag: archive/raspbian/2025.7-2+rpi1^2^2~6^2~5^2~3^2 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:///%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:/?a=commitdiff_plain;h=688ab1aa8ec2c720c21b0026aef8ce9c4f7efac9;p=ostree.git commit: Clarify that syncfs is of repo/tmp We saw this in an error message: ``` error: Generating commit from rootfs: syncfs: Not a directory ``` I'm pretty sure it's this function call but let's be a bit more sure by adding a bit more context. --- diff --git a/src/libostree/ostree-repo-commit.c b/src/libostree/ostree-repo-commit.c index c5a47d32..4bf845c4 100644 --- a/src/libostree/ostree-repo-commit.c +++ b/src/libostree/ostree-repo-commit.c @@ -2233,7 +2233,7 @@ ostree_repo_commit_transaction (OstreeRepo *self, OstreeRepoTransactionStats *ou if (!self->disable_fsync && g_getenv ("OSTREE_SUPPRESS_SYNCFS") == NULL) { if (syncfs (self->tmp_dir_fd) < 0) - return glnx_throw_errno_prefix (error, "syncfs"); + return glnx_throw_errno_prefix (error, "syncfs(repo/tmp)"); } if (!rename_pending_loose_objects (self, cancellable, error))